Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 32fb1939 authored by Peter Senna Tschudin's avatar Peter Senna Tschudin Committed by Greg Kroah-Hartman
Browse files

usb/host/fotg210: Add function: output_buf_tds_dir() 



checkpatch complains about too many leading tabs because the switch
statement starts after 6 tabs.

fill_periodic_buffer() -> for() -> do -> switch() -> if() ->
list_for_each_entry() and finally the last switch().

This patch moves the list_for_each_entry() and the last switch() to a
new function named output_buf_tds_dir(). This change makes the code
easier to read and calm down checkpatch. This patch changes it to:

fill_periodic_buffer() -> for() -> do -> switch() -> if() ->
output_buf_tds_dir()

Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c4d66b5f

drivers/usb/host/fotg210-hcd.c

+31 −31
Original line number Original line Diff line number Diff line
@@ -493,6 +493,34 @@ static ssize_t fill_async_buffer(struct debug_buffer *buf) 
	return strlen(buf->output_buf);

	return strlen(buf->output_buf);

}

}





/* count tds, get ep direction */

static unsigned output_buf_tds_dir(char *buf, struct fotg210_hcd *fotg210,

		struct fotg210_qh_hw *hw, struct fotg210_qh *qh, unsigned size)

{

	u32 scratch = hc32_to_cpup(fotg210, &hw->hw_info1);

	struct fotg210_qtd *qtd;

	char *type = "";

	unsigned temp = 0;



	/* count tds, get ep direction */

	list_for_each_entry(qtd, &qh->qtd_list, qtd_list) {

		temp++;

		switch ((hc32_to_cpu(fotg210, qtd->hw_token) >> 8) & 0x03) {

		case 0:

			type = "out";

			continue;

		case 1:

			type = "in";

			continue;

		}

	}



	return scnprintf(buf, size, "(%c%d ep%d%s [%d/%d] q%d p%d)",

			speed_char(scratch), scratch & 0x007f,

			(scratch >> 8) & 0x000f, type, qh->usecs,

			qh->c_usecs, temp, (scratch >> 16) & 0x7ff);

}



#define DBG_SCHED_LIMIT 64

#define DBG_SCHED_LIMIT 64

static ssize_t fill_periodic_buffer(struct debug_buffer *buf)

static ssize_t fill_periodic_buffer(struct debug_buffer *buf)

{

{
@@ -564,37 +592,9 @@ static ssize_t fill_periodic_buffer(struct debug_buffer *buf) 
				}

				}

				/* show more info the first time around */

				/* show more info the first time around */

				if (temp == seen_count) {

				if (temp == seen_count) {

					u32 scratch = hc32_to_cpup(fotg210,

					temp = output_buf_tds_dir(next,

							&hw->hw_info1);

							fotg210, hw,

					struct fotg210_qtd *qtd;

							p.qh, size);

					char *type = "";



					/* count tds, get ep direction */

					temp = 0;

					list_for_each_entry(qtd,

							&p.qh->qtd_list,

							qtd_list) {

						temp++;

						switch (0x03 & (hc32_to_cpu(

							fotg210,

							qtd->hw_token) >> 8)) {

						case 0:

							type = "out";

							continue;

						case 1:

							type = "in";

							continue;

						}

					}



					temp = scnprintf(next, size,

						"(%c%d ep%d%s [%d/%d] q%d p%d)",

						speed_char(scratch),

						scratch & 0x007f,

						(scratch >> 8) & 0x000f, type,

						p.qh->usecs, p.qh->c_usecs,

						temp,

						0x7ff & (scratch >> 16));





					if (seen_count < DBG_SCHED_LIMIT)

					if (seen_count < DBG_SCHED_LIMIT)

						seen[seen_count++].qh = p.qh;

						seen[seen_count++].qh = p.qh;