Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 31dcbf99 authored by Duncan Sands's avatar Duncan Sands Committed by Linus Torvalds
Browse files

V4L/DVB (3488): Snd_cx88_create: don't dereference NULL core 



If the call to cx88_core_get returns a NULL value, it is dereferenced
by cx88_reset, and perhaps by cx88_core_put.  Spotted by the Coverity
checker.

Signed-off-by: default avatarDuncan Sands <baldrick@free.fr>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent ae24601b

drivers/media/video/cx88/cx88-alsa.c

+5 −5
Original line number Diff line number Diff line
@@ -672,6 +672,11 @@ static int __devinit snd_cx88_create(snd_card_t *card, struct pci_dev *pci, 
	chip = (snd_cx88_card_t *) card->private_data;



	core = cx88_core_get(pci);

	if (NULL == core) {

		err = -EINVAL;

		kfree (chip);

		return err;

	}



	if (!pci_dma_supported(pci,0xffffffff)) {

		dprintk(0, "%s/1: Oops: no 32bit PCI DMA ???\n",core->name);
@@ -688,11 +693,6 @@ static int __devinit snd_cx88_create(snd_card_t *card, struct pci_dev *pci, 
	spin_lock_init(&chip->reg_lock);



	cx88_reset(core);

	if (NULL == core) {

		err = -EINVAL;

		kfree (chip);

		return err;

	}

	chip->core = core;



	/* get irq */