Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3028457f authored by Jerry Hoemann's avatar Jerry Hoemann Committed by Greg Kroah-Hartman
Browse files

watchdog: hpwdt: SMBIOS check 



commit c42cbe41727a138905a28f8e0b00c147be77ee93 upstream.

This corrects:
commit cce78da7 ("watchdog: hpwdt: Add check for UEFI bits")

The test on HPE SMBIOS extension type 219 record "Misc Features"
bits for UEFI support is incorrect.  The definition of the Misc Features
bits in the HPE SMBIOS OEM Extensions specification (and related
firmware) was changed to use a different pair of bits to
represent UEFI supported.  Howerver, a corresponding change
to Linux was missed.

Current code/platform work because the iCRU test is working.
But purpose of cce78da7 is to ensure correct functionality
on future systems where iCRU isn't supported.

Signed-off-by: default avatarJerry Hoemann <jerry.hoemann@hpe.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3378b95b

drivers/watchdog/hpwdt.c

+1 −1
Original line number Diff line number Diff line
@@ -700,7 +700,7 @@ static void dmi_find_icru(const struct dmi_header *dm, void *dummy) 
		smbios_proliant_ptr = (struct smbios_proliant_info *) dm;

		if (smbios_proliant_ptr->misc_features & 0x01)

			is_icru = 1;

		if (smbios_proliant_ptr->misc_features & 0x408)

		if (smbios_proliant_ptr->misc_features & 0x1400)

			is_uefi = 1;

	}

}