Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 27c4db39 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (acpi_power_meter) Cleanup and optimizations 



An unsigned value can not be smaller than 0. Remove the check for it.
Use DIV_ROUND_CLOSEST for divide operations converting milli-degrees C into
degrees C. Limit maximum accepted trip point temperature to INT_MAX.

This patch fixes Coverity #115214: Unsigned compared against 0

Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Acked-by: default avatarJean Delvare <khali@linux-fr.org>
parent 27f8b135

drivers/hwmon/acpi_power_meter.c

+3 −3
Original line number Diff line number Diff line
@@ -237,7 +237,7 @@ static ssize_t set_cap(struct device *dev, struct device_attribute *devattr, 
	if (res)

		return res;



	temp /= 1000;

	temp = DIV_ROUND_CLOSEST(temp, 1000);

	if (temp > resource->caps.max_cap || temp < resource->caps.min_cap)

		return -EINVAL;

	arg0.integer.value = temp;
@@ -307,8 +307,8 @@ static ssize_t set_trip(struct device *dev, struct device_attribute *devattr, 
	if (res)

		return res;



	temp /= 1000;

	if (temp < 0)

	temp = DIV_ROUND_CLOSEST(temp, 1000);

	if (temp > INT_MAX)

		return -EINVAL;



	mutex_lock(&resource->lock);