Commit 258006d1 authored Apr 02, 2010 by Julia Lawall Committed by David Woodhouse May 10, 2010

mtd: maps: Eliminate use after free

Moved the debugging message before the call to map_destroy, which frees its
argument.  The message is also slightly changed to reflect its new
position.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression E,E2;
@@

del_mtd_device(E)
...
(
  E = E2
|
* E
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

parent c4e77376

drivers/mtd/maps/pcmciamtd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -692,8 +692,8 @@ static void pcmciamtd_detach(struct pcmcia_device *link)

		if(dev->mtd_info) {
		del_mtd_device(dev->mtd_info);
		info("mtd%d: Removing", dev->mtd_info->index);
		map_destroy(dev->mtd_info);
		info("mtd%d: Removed", dev->mtd_info->index);
		}

		pcmciamtd_release(link);