Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 239a7dc2 authored by Mike Christie's avatar Mike Christie Committed by James Bottomley
Browse files

[SCSI] iscsi_transport: Check iscsi interface skb allocation return value 



Let's not oops when we cannot allocate a skb! Add a check
for if alloc_skb fails.

Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 5c9cfedd

drivers/scsi/scsi_transport_iscsi.c

+4 −6
Original line number Diff line number Diff line
@@ -609,12 +609,10 @@ iscsi_if_send_reply(int pid, int seq, int type, int done, int multi, 
	int t = done ? NLMSG_DONE : type;



	skb = alloc_skb(len, GFP_ATOMIC);

	/*

	 * FIXME:

	 * user is supposed to react on iferror == -ENOMEM;

	 * see iscsi_if_rx().

	 */

	BUG_ON(!skb);

	if (!skb) {

		printk(KERN_ERR "Could not allocate skb to send reply.\n");

		return -ENOMEM;

	}



	nlh = __nlmsg_put(skb, pid, seq, t, (len - sizeof(*nlh)), 0);

	nlh->nlmsg_flags = flags;