Commit 238b1eaa authored Oct 30, 2013 by Peter Huewe Committed by Peter Huewe Jan 06, 2014

tpm/tpm_ppi: Check return value of acpi_get_name



If
 status = acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer);
fails for whatever reason and does not return AE_OK
 if (strstr(buffer.pointer, context) != NULL) {
does dereference a null pointer.

-> Check the return value and return the status to the caller

Found by coverity
Cc: stable@vger.kernel.org
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>

parent 747d35bd

drivers/char/tpm/tpm_ppi.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -30,6 +30,9 @@ static acpi_status ppi_callback(acpi_handle handle, u32 level, void *context,
		acpi_status status;
		struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
		status = acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer);
		if (ACPI_FAILURE(status))
		return status;

		if (strstr(buffer.pointer, context) != NULL) {
		*return_value = handle;
		kfree(buffer.pointer);