Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 217045ea authored by jiad's avatar jiad Committed by Gerrit - the friendly Code Review server
Browse files

qcacld-3.0: Fix HDD IPA RM enablement 

With IPA WDI unified API, IPA PM is used instad of IPA RM
for power/resource management. When checking if IPA RM is
enabled or not, HDD_IPA_RM_ENABLE_MASK is thus not applicable
for WDI unified API.

Fix is to always return true for IPA WDI unified API for power
efficiency.

Change-Id: I047b3156cf00002142dd3acb021cfb6ce64489ee
CRs-Fixed: 2283088
parent ebc47686

core/hdd/src/wlan_hdd_ipa.c

+26 −11
Original line number Diff line number Diff line
@@ -869,17 +869,6 @@ static inline bool hdd_ipa_is_ipv6_enabled(hdd_context_t *hdd_ctx) 
	return HDD_IPA_IS_CONFIG_ENABLED(hdd_ctx, HDD_IPA_IPV6_ENABLE_MASK);

}



/**

 * hdd_ipa_is_rm_enabled() - Is IPA resource manager enabled?

 * @hdd_ipa: Global HDD IPA context

 *

 * Return: true if resource manager is enabled, otherwise false

 */

static inline bool hdd_ipa_is_rm_enabled(hdd_context_t *hdd_ctx)

{

	return HDD_IPA_IS_CONFIG_ENABLED(hdd_ctx, HDD_IPA_RM_ENABLE_MASK);

}



/**

 * hdd_ipa_is_rt_debugging_enabled() - Is IPA real-time debug enabled?

 * @hdd_ipa: Global HDD IPA context
@@ -1055,6 +1044,21 @@ static void hdd_ipa_wdi_init_metering(struct hdd_ipa_priv *ipa_ctxt, void *in) 


#ifdef CONFIG_IPA_WDI_UNIFIED_API



/**

 * hdd_ipa_is_rm_enabled() - Is IPA resource manager enabled?

 * @hdd_ipa: Global HDD IPA context

 *

 * IPA RM is deprecated and IPA PM is involved. WLAN driver

 * has no control over IPA PM and thus we could regard IPA

 * RM as always enabled for power efficiency.

 *

 * Return: true

 */

static inline bool hdd_ipa_is_rm_enabled(hdd_context_t *hdd_ctx)

{

	return true;

}



/**

 * hdd_ipa_is_clk_scaling_enabled() - Is IPA clock scaling enabled?

 * @hdd_ipa: Global HDD IPA context
@@ -1586,6 +1590,17 @@ int hdd_ipa_uc_smmu_map(bool map, uint32_t num_buf, qdf_mem_info_t *buf_arr) 
}

#else /* CONFIG_IPA_WDI_UNIFIED_API */



/**

 * hdd_ipa_is_rm_enabled() - Is IPA resource manager enabled?

 * @hdd_ipa: Global HDD IPA context

 *

 * Return: true if resource manager is enabled, otherwise false

 */

static inline bool hdd_ipa_is_rm_enabled(hdd_context_t *hdd_ctx)

{

	return HDD_IPA_IS_CONFIG_ENABLED(hdd_ctx, HDD_IPA_RM_ENABLE_MASK);

}



/**

 * hdd_ipa_is_clk_scaling_enabled() - Is IPA clock scaling enabled?

 * @hdd_ipa: Global HDD IPA context