Commit 20959c4b authored Oct 01, 2014 by Andy Grover Committed by Nicholas Bellinger Oct 02, 2014

target: Remove unneeded check in sbc_parse_cdb



The check of SCF_SCSI_DATA_CDB seems to be a remnant from before hch's
refactoring of this function. There are no places where that flag is set
that cmd->execute_cmd isn't also set.

Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 082f58ac

drivers/target/target_core_sbc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -948,7 +948,7 @@ sbc_parse_cdb(struct se_cmd cmd, struct sbc_ops ops)
		}

		/* reject any command that we don't have a handler for */
		if (!(cmd->se_cmd_flags & SCF_SCSI_DATA_CDB) && !cmd->execute_cmd)
		if (!cmd->execute_cmd)
		return TCM_UNSUPPORTED_SCSI_OPCODE;

		if (cmd->se_cmd_flags & SCF_SCSI_DATA_CDB) {