Commit 1f5adadc authored Nov 24, 2016 by Filipe Manana Committed by Greg Kroah-Hartman Jan 06, 2017

Btrfs: fix qgroup rescan worker initialization

commit 8d9eddad19467b008e0c881bc3133d7da94b7ec1 upstream.

We were setting the qgroup_rescan_running flag to true only after the
rescan worker started (which is a task run by a queue). So if a user
space task starts a rescan and immediately after asks to wait for the
rescan worker to finish, this second call might happen before the rescan
worker task starts running, in which case the rescan wait ioctl returns
immediatley, not waiting for the rescan worker to finish.

This was making the fstest btrfs/022 fail very often.

Fixes: d2c609b834d6 (btrfs: properly track when rescan worker is running)
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b5e715ed

fs/btrfs/qgroup.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -2283,10 +2283,6 @@ static void btrfs_qgroup_rescan_worker(struct btrfs_work *work)
		int err = -ENOMEM;
		int ret = 0;

		mutex_lock(&fs_info->qgroup_rescan_lock);
		fs_info->qgroup_rescan_running = true;
		mutex_unlock(&fs_info->qgroup_rescan_lock);

		path = btrfs_alloc_path();
		if (!path)
		goto out;
		@@ -2397,6 +2393,7 @@ qgroup_rescan_init(struct btrfs_fs_info *fs_info, u64 progress_objectid,
		sizeof(fs_info->qgroup_rescan_progress));
		fs_info->qgroup_rescan_progress.objectid = progress_objectid;
		init_completion(&fs_info->qgroup_rescan_completion);
		fs_info->qgroup_rescan_running = true;

		spin_unlock(&fs_info->qgroup_lock);
		mutex_unlock(&fs_info->qgroup_rescan_lock);