Commit 1e91b0d6 authored Oct 04, 2017 by Stuart Hayes Committed by Greg Kroah-Hartman Dec 25, 2017

PCI: Create SR-IOV virtfn/physfn links before attaching driver




[ Upstream commit 27d6162944b9b34c32cd5841acd21786637ee743 ]

When creating virtual functions, create the "virtfn%u" and "physfn" links
in sysfs *before* attaching the driver instead of after.  When we attach
the driver to the new virtual network interface first, there is a race when
the driver attaches to the new sends out an "add" udev event, and the
network interface naming software (biosdevname or systemd, for example)
tries to look at these links.

Signed-off-by: Stuart Hayes <stuart.w.hayes@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a916c415

drivers/pci/iov.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -161,7 +161,6 @@ static int virtfn_add(struct pci_dev *dev, int id, int reset)
		pci_device_add(virtfn, virtfn->bus);
		mutex_unlock(&iov->dev->sriov->lock);

		pci_bus_add_device(virtfn);
		sprintf(buf, "virtfn%u", id);
		rc = sysfs_create_link(&dev->dev.kobj, &virtfn->dev.kobj, buf);
		if (rc)
		@@ -172,6 +171,8 @@ static int virtfn_add(struct pci_dev *dev, int id, int reset)

		kobject_uevent(&virtfn->dev.kobj, KOBJ_CHANGE);

		pci_bus_add_device(virtfn);

		return 0;

		failed2: