Commit 1dc0a24e authored Mar 30, 2021 by Sergey Shtylyov Committed by Greg Kroah-Hartman May 22, 2021

scsi: jazz_esp: Add IRQ check

[ Upstream commit 38fca15c29db6ed06e894ac194502633e2a7d1fb ]

The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to request_irq() (which takes
*unsigned* IRQ #), causing it to fail with -EINVAL, overriding the real
error code.  Stop calling request_irq() with the invalid IRQ #s.

Link: https://lore.kernel.org/r/594aa9ae-2215-49f6-f73c-33bd38989912@omprussia.ru


Fixes: 352e921f ("[SCSI] jazz_esp: converted to use esp_core")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent d3170c13

drivers/scsi/jazz_esp.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -170,7 +170,9 @@ static int esp_jazz_probe(struct platform_device *dev)
	if (!esp->command_block)		if (!esp->command_block)
	goto fail_unmap_regs;		goto fail_unmap_regs;

	host->irq = platform_get_irq(dev, 0);		host->irq = err = platform_get_irq(dev, 0);
			if (err < 0)
			goto fail_unmap_command_block;
	err = request_irq(host->irq, scsi_esp_intr, IRQF_SHARED, "ESP", esp);		err = request_irq(host->irq, scsi_esp_intr, IRQF_SHARED, "ESP", esp);
	if (err < 0)		if (err < 0)
	goto fail_unmap_command_block;		goto fail_unmap_command_block;