Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1da32123 authored by Subbaraman Narayanamurthy's avatar Subbaraman Narayanamurthy
Browse files

input: qpnp-power-on: Cleanup the qpnp-power-on driver 



Fix the following in qpnp-power-on driver:
- Use GENMASK for bit mask
- Remove unused module parameter
- Use nested comments properly wherever applicable
- Fix conditional block formatting and typos
- Use const qualifier for of_device_id table

Change-Id: Ib9dd9be6cafad4c7aec1c88d9828ef1ebbe2a1c3
Signed-off-by: default avatarSubbaraman Narayanamurthy <subbaram@codeaurora.org>
parent a27b2f17

drivers/input/qpnp-power-on.c

+21 −29
Original line number Diff line number Diff line
@@ -32,11 +32,6 @@ 
#include <linux/regulator/of_regulator.h>

#include <linux/qpnp/power-on.h>



#define CREATE_MASK(NUM_BITS, POS) \

	((unsigned char) (((1 << (NUM_BITS)) - 1) << (POS)))

#define PON_MASK(MSB_BIT, LSB_BIT) \

	CREATE_MASK(MSB_BIT - LSB_BIT + 1, LSB_BIT)



#define PMIC_VER_8941           0x01

#define PMIC_VERSION_REG        0x0105

#define PMIC_VERSION_REV4_REG   0x0103
@@ -135,7 +130,7 @@ 
#define QPNP_PON_S3_SRC_KPDPWR_AND_RESIN	2

#define QPNP_PON_S3_SRC_KPDPWR_OR_RESIN		3

#define QPNP_PON_S3_SRC_MASK			0x3

#define QPNP_PON_HARD_RESET_MASK		PON_MASK(7, 5)

#define QPNP_PON_HARD_RESET_MASK		GENMASK(7, 5)



#define QPNP_PON_UVLO_DLOAD_EN			BIT(7)

#define QPNP_PON_SMPL_EN			BIT(7)
@@ -292,14 +287,6 @@ static const char * const qpnp_poff_reason[] = { 
	[39] = "Triggered from S3_RESET_KPDPWR_ANDOR_RESIN (power key and/or reset line)",

};



/*

 * On the kernel command line specify

 * qpnp-power-on.warm_boot=1 to indicate a warm

 * boot of the device.

 */

static int warm_boot;

module_param(warm_boot, int, 0);



static int

qpnp_pon_masked_write(struct qpnp_pon *pon, u16 addr, u8 mask, u8 val)

{
@@ -349,10 +336,10 @@ int qpnp_pon_set_restart_reason(enum pon_restart_reason reason) 


	if (is_pon_gen2(pon))

		rc = qpnp_pon_masked_write(pon, QPNP_PON_SOFT_RB_SPARE(pon),

					   PON_MASK(7, 1), (reason << 1));

					   GENMASK(7, 1), (reason << 1));

	else

		rc = qpnp_pon_masked_write(pon, QPNP_PON_SOFT_RB_SPARE(pon),

					   PON_MASK(7, 2), (reason << 2));

					   GENMASK(7, 2), (reason << 2));



	if (rc)

		dev_err(&pon->pdev->dev,
@@ -795,7 +782,8 @@ qpnp_pon_input_dispatch(struct qpnp_pon *pon, u32 pon_type) 
					cfg->key_code, pon_rt_sts);

	key_status = pon_rt_sts & pon_rt_bit;



	/* simulate press event in case release event occured

	/*

	 * simulate press event in case release event occurred

	 * without a press event

	 */

	if (!cfg->old_state && !key_status) {
@@ -1280,10 +1268,12 @@ static int qpnp_pon_config_init(struct qpnp_pon *pon) 
				}

			}



			/* If the value read from REVISION2 register is 0x00,

			   then there is a single register to control s2 reset.

			   Otherwise there are separate registers for s2 reset

			   type and s2 reset enable */

			/*

			 * If the value read from REVISION2 register is 0x00,

			 * then there is a single register to control s2 reset.

			 * Otherwise there are separate registers for s2 reset

			 * type and s2 reset enable.

			 */

			if (pon->pon_ver == QPNP_PON_GEN1_V1) {

				cfg->s2_cntl_addr = cfg->s2_cntl2_addr =

					QPNP_PON_KPDPWR_S2_CNTL(pon);
@@ -1344,8 +1334,10 @@ static int qpnp_pon_config_init(struct qpnp_pon *pon) 
					return rc;

				}



				/*PM8941 V3 does not have harware bug. Hence

				bark is not required from PMIC versions 3.0*/

				/*

				 * PM8941 V3 does not have hardware bug. Hence

				 * bark is not required from PMIC versions 3.0.

				 */

				if (!(revid_rev4 == PMIC8941_V1_REV4 ||

					revid_rev4 == PMIC8941_V2_REV4)) {

					cfg->support_reset = false;
@@ -1669,7 +1661,8 @@ static int pon_regulator_init(struct qpnp_pon *pon) 
			return rc;

		}



		init_data = of_get_regulator_init_data(dev, node, &pon_reg->rdesc);

		init_data = of_get_regulator_init_data(dev, node,

				&pon_reg->rdesc);

		if (!init_data) {

			dev_err(dev, "regulator init data is missing\n");

			return -EINVAL;
@@ -1847,8 +1840,7 @@ static void qpnp_pon_debugfs_init(struct platform_device *pdev) 
		dev_err(&pon->pdev->dev,

			"Unable to create debugfs directory\n");

	} else {

		ent = debugfs_create_file("uvlo_panic",

				S_IFREG | S_IWUSR | S_IRUGO,

		ent = debugfs_create_file("uvlo_panic", 0644,

				pon->debugfs, pon, &qpnp_pon_debugfs_uvlo_fops);

		if (!ent)

			dev_err(&pon->pdev->dev,
@@ -2308,7 +2300,7 @@ static int qpnp_pon_remove(struct platform_device *pdev) 
	return 0;

}



static struct of_device_id spmi_match_table[] = {

static const struct of_device_id spmi_match_table[] = {

	{ .compatible = "qcom,qpnp-power-on", },

	{}

};