Commit 1d30686d authored Sep 17, 2014 by Nicholas Bellinger

iscsi-target: Drop duplicate __iscsi_target_login_thread check

This patch drops the now duplicate + unnecessary check for -ENODEV from
iscsi_transport->iscsit_accept_np() for jumping to out:, or immediately
returning 1 in __iscsi_target_login_thread() code.

Since commit 81a9c5e7 the jump to out: and returning 1 have the same
effect, and end up hitting the ISCSI_NP_THREAD_SHUTDOWN check regardless
at the top of __iscsi_target_login_thread() during next loop iteration.

So that said, it's safe to go ahead and remove this duplicate check.

Reported-by: Joern Engel <joern@logfs.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 5c22e229

drivers/target/iscsi/iscsi_target_login.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1267,8 +1267,6 @@ static int __iscsi_target_login_thread(struct iscsi_np *np)
		iscsit_put_transport(conn->conn_transport);
		kfree(conn);
		conn = NULL;
		if (ret == -ENODEV)
		goto out;
		/* Get another socket */
		return 1;
		}