Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1cde201d authored by Toshiyuki Okajima's avatar Toshiyuki Okajima Committed by Jan Kara
Browse files

ext3: fix message in ext3_remount for rw-remount case 



If there are some inodes in orphan list while a filesystem is being
read-only mounted, we should recommend that peole umount and then
mount it when they try to remount with read-write. But the current
message and comment recommend that they umount and then remount it
which may be slightly misleading.

Signed-off-by: default avatarToshiyuki Okajima <toshi.okajima@jp.fujitsu.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent 5a0143a4

fs/ext3/super.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -2669,13 +2669,13 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) 
			/*

			/*

			 * If we have an unprocessed orphan list hanging

			 * If we have an unprocessed orphan list hanging

			 * around from a previously readonly bdev mount,

			 * around from a previously readonly bdev mount,

			 * require a full umount/remount for now.

			 * require a full umount & mount for now.

			 */

			 */

			if (es->s_last_orphan) {

			if (es->s_last_orphan) {

				ext3_msg(sb, KERN_WARNING, "warning: couldn't "

				ext3_msg(sb, KERN_WARNING, "warning: couldn't "

				       "remount RDWR because of unprocessed "

				       "remount RDWR because of unprocessed "

				       "orphan inode list.  Please "

				       "orphan inode list.  Please "

				       "umount/remount instead.");

				       "umount & mount instead.");

				err = -EINVAL;

				err = -EINVAL;

				goto restore_opts;

				goto restore_opts;

			}

			}