Commit 1be10a88 authored Sep 04, 2009 by J. Bruce Fields

nfsd4: filehandle leak or error exit from fh_compose()



A number of callers (nfsd4_encode_fattr(), at least) don't bother to
release the filehandle returned to fh_compose() if fh_compose() returns
an error.  So, modify fh_compose() to release the filehandle before
returning an error.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>

parent 2671a4bf

fs/nfsd/nfsfh.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -557,9 +557,11 @@ fh_compose(struct svc_fh fhp, struct svc_export exp, struct dentry *dentry,

		if (inode)
		_fh_update(fhp, exp, dentry);
		if (fhp->fh_handle.fh_fileid_type == 255)
		if (fhp->fh_handle.fh_fileid_type == 255) {
		fh_put(fhp);
		return nfserr_opnotsupp;
		}
		}

		return 0;
		}