Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1aa0a528 authored by Szymon Heidrich's avatar Szymon Heidrich Committed by Pavel Machek
Browse files

USB: gadget: validate interface OS descriptor requests 



commit 75e5b4849b81e19e9efe1654b30d7f3151c33c2c upstream.

Stall the control endpoint in case provided index exceeds array size of
MAX_CONFIG_INTERFACES or when the retrieved function pointer is null.

Signed-off-by: default avatarSzymon Heidrich <szymon.heidrich@gmail.com>
Cc: stable@kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5f859c39

drivers/usb/gadget/composite.c

+3 −0
Original line number Diff line number Diff line
@@ -1776,6 +1776,9 @@ unknown: 
				if (w_index != 0x5 || (w_value >> 8))

					break;

				interface = w_value & 0xFF;

				if (interface >= MAX_CONFIG_INTERFACES ||

				    !os_desc_cfg->interface[interface])

					break;

				buf[6] = w_index;

				if (w_length == 0x0A) {

					count = count_ext_prop(os_desc_cfg,