Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1a4f1f28 authored by Kangjie Lu's avatar Kangjie Lu Committed by Amit Pundir
Browse files

UPSTREAM: ALSA: timer: Fix leak in events via snd_timer_user_ccallback 



(cherry pick from commit 9a47e9cff994f37f7f0dbd9ae23740d0f64f9fe6)

The stack object “r1” has a total size of 32 bytes. Its field
“event” and “val” both contain 4 bytes padding. These 8 bytes
padding bytes are sent to user without being initialized.

Signed-off-by: default avatarKangjie Lu <kjlu@gatech.edu>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Bug: 28980217
Change-Id: I2e4c27352894b9f1f4c808b8db3ae5f9284faec1
parent 7e6a8116

sound/core/timer.c

+1 −0
Original line number Diff line number Diff line
@@ -1247,6 +1247,7 @@ static void snd_timer_user_ccallback(struct snd_timer_instance *timeri, 
		tu->tstamp = *tstamp;

	if ((tu->filter & (1 << event)) == 0 || !tu->tread)

		return;

	memset(&r1, 0, sizeof(r1));

	r1.event = event;

	r1.tstamp = *tstamp;

	r1.val = resolution;