Commit 19d54279 authored Jan 02, 2021 by Dinghao Liu Committed by Greg Kroah-Hartman Mar 03, 2021

media: tm6000: Fix memleak in tm6000_start_stream



[ Upstream commit 76aaf8a96771c16365b8510f1fb97738dc88026e ]

When usb_clear_halt() fails, dvb->bulk_urb->transfer_buffer
and dvb->bulk_urb should be freed just like when
usb_submit_urb() fails.

Fixes: 3169c9b2 ("V4L/DVB (12788): tm6000: Add initial DVB-T support")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 667b1de3

drivers/media/usb/tm6000/tm6000-dvb.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -158,6 +158,10 @@ static int tm6000_start_stream(struct tm6000_core *dev)
		if (ret < 0) {
		printk(KERN_ERR "tm6000: error %i in %s during pipe reset\n",
		ret, __func__);

		kfree(dvb->bulk_urb->transfer_buffer);
		usb_free_urb(dvb->bulk_urb);
		dvb->bulk_urb = NULL;
		return ret;
		} else
		printk(KERN_ERR "tm6000: pipe resetted\n");