Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 18b9f679 authored by NeilBrown's avatar NeilBrown
Browse files

md-cluster: remove inappropriate try_module_get from join()



md_setup_cluster already calls try_module_get(), so this
try_module_get isn't needed.
Also, there is no matching module_put (except in error patch),
so this leaves an unbalanced module count.

Signed-off-by: default avatarNeilBrown <neilb@suse.com>
parent 6022e75b
Loading
Loading
Loading
Loading
+0 −4
Original line number Diff line number Diff line
@@ -687,9 +687,6 @@ static int join(struct mddev *mddev, int nodes)
	int ret, ops_rv;
	char str[64];

	if (!try_module_get(THIS_MODULE))
		return -ENOENT;

	cinfo = kzalloc(sizeof(struct md_cluster_info), GFP_KERNEL);
	if (!cinfo)
		return -ENOMEM;
@@ -771,7 +768,6 @@ err:
		dlm_release_lockspace(cinfo->lockspace, 2);
	mddev->cluster_info = NULL;
	kfree(cinfo);
	module_put(THIS_MODULE);
	return ret;
}