Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 176dd985 authored by Henrique de Moraes Holschuh's avatar Henrique de Moraes Holschuh Committed by Len Brown
Browse files

thinkpad-acpi: drop HKEY event 0x5010 



HKEY event 0x5010 is useless to us: old ThinkPads don't issue it.  Newer
ThinkPads won't issue it anymore.  And all ThinkPads issue 0x1010 and
0x1011 events.

Just silently drop it instead of sending it to userspace.

Signed-off-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 4be73005

Documentation/laptops/thinkpad-acpi.txt

+1 −1
Original line number Original line Diff line number Diff line
@@ -525,6 +525,7 @@ compatibility purposes when hotkey_report_mode is set to 1. 
0x2305		System is waking up from suspend to eject bay

0x2305		System is waking up from suspend to eject bay

0x2404		System is waking up from hibernation to undock

0x2404		System is waking up from hibernation to undock

0x2405		System is waking up from hibernation to eject bay

0x2405		System is waking up from hibernation to eject bay

0x5010		Brightness level changed/control event





The above events are never propagated by the driver.

The above events are never propagated by the driver.
@@ -532,7 +533,6 @@ The above events are never propagated by the driver. 
0x4003		Undocked (see 0x2x04), can sleep again

0x4003		Undocked (see 0x2x04), can sleep again

0x500B		Tablet pen inserted into its storage bay

0x500B		Tablet pen inserted into its storage bay

0x500C		Tablet pen removed from its storage bay

0x500C		Tablet pen removed from its storage bay

0x5010		Brightness level changed (newer Lenovo BIOSes)





The above events are propagated by the driver.

The above events are propagated by the driver.

drivers/platform/x86/thinkpad_acpi.c

+4 −4
Original line number Original line Diff line number Diff line
@@ -3305,7 +3305,6 @@ static bool hotkey_notify_usrevent(const u32 hkey, 
	*ignore_acpi_ev = false;

	*ignore_acpi_ev = false;





	switch (hkey) {

	switch (hkey) {

	case 0x5010: /* Lenovo new BIOS: brightness changed */

	case 0x500b: /* X61t: tablet pen inserted into bay */

	case 0x500b: /* X61t: tablet pen inserted into bay */

	case 0x500c: /* X61t: tablet pen removed from bay */

	case 0x500c: /* X61t: tablet pen removed from bay */

		return true;

		return true;
@@ -3317,9 +3316,10 @@ static bool hotkey_notify_usrevent(const u32 hkey, 
		*send_acpi_ev = false;

		*send_acpi_ev = false;

		return true;

		return true;





	case 0x5001:

	case 0x5001: /* Lid close */

	case 0x5002:

	case 0x5002: /* Lid open */

		/* LID switch events.  Do not propagate */

	case 0x5010: /* brightness control */

		/* do not propagate these events */

		*ignore_acpi_ev = true;

		*ignore_acpi_ev = true;

		return true;

		return true;