Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 16798d34 authored by Matthew R. Ochs's avatar Matthew R. Ochs Committed by James Bottomley
Browse files

cxlflash: Fix async interrupt bypass logic 



A bug was introduced earlier in the development cycle when cleaning
up logic statements. Instead of skipping bits that are not set, set
bits are skipped, causing async interrupts to not be handled correctly.

To fix, simply add back in the proper evaluation for an unset bit.

Signed-off-by: default avatarMatthew R. Ochs <mrochs@linux.vnet.ibm.com>
Signed-off-by: default avatarManoj N. Kumar <manoj@linux.vnet.ibm.com>
Reviewed-by: default avatarBrian King <brking@linux.vnet.ibm.com>
Reviewed-by: default avatarAndrew Donnellan <andrew.donnellan@au1.ibm.com>
Reviewed-by: default avatarTomas Henzl <thenzl@redhat.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Odin.com>
parent ef51074a

drivers/scsi/cxlflash/main.c

+1 −1
Original line number Diff line number Diff line
@@ -1315,7 +1315,7 @@ static irqreturn_t cxlflash_async_err_irq(int irq, void *data) 
	/* check each bit that is on */

	for (i = 0; reg_unmasked; i++, reg_unmasked = (reg_unmasked >> 1)) {

		info = find_ainfo(1ULL << i);

		if ((reg_unmasked & 0x1) || !info)

		if (((reg_unmasked & 0x1) == 0) || !info)

			continue;



		port = info->port;