Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1668844e authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

[media] siano: fix sparse warnings 



drivers/media/common/siano/smsdvb-main.c:47:5: warning: symbol 'sms_to_guard_interval_table' was not declared. Should it be static?
drivers/media/common/siano/smsdvb-main.c:54:5: warning: symbol 'sms_to_code_rate_table' was not declared. Should it be static?
drivers/media/common/siano/smsdvb-main.c:63:5: warning: symbol 'sms_to_hierarchy_table' was not declared. Should it be static?
drivers/media/common/siano/smsdvb-main.c:70:5: warning: symbol 'sms_to_modulation_table' was not declared. Should it be static?
drivers/media/common/siano/smscoreapi.c:925:35: warning: cast to restricted __le32
drivers/media/common/siano/smscoreapi.c:926:28: warning: cast to restricted __le32

Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent d364016d

drivers/media/common/siano/smscoreapi.c

+2 −2
Original line number Diff line number Diff line
@@ -922,8 +922,8 @@ static int smscore_load_firmware_family2(struct smscore_device_t *coredev, 
	u32 i, *ptr;

	u8 *payload = firmware->payload;

	int rc = 0;

	firmware->start_address = le32_to_cpu(firmware->start_address);

	firmware->length = le32_to_cpu(firmware->length);

	firmware->start_address = le32_to_cpup((__le32 *)&firmware->start_address);

	firmware->length = le32_to_cpup((__le32 *)&firmware->length);



	mem_address = firmware->start_address;

drivers/media/common/siano/smsdvb-main.c

+4 −4
Original line number Diff line number Diff line
@@ -44,14 +44,14 @@ module_param_named(debug, sms_dbg, int, 0644); 
MODULE_PARM_DESC(debug, "set debug level (info=1, adv=2 (or-able))");





u32 sms_to_guard_interval_table[] = {

static u32 sms_to_guard_interval_table[] = {

	[0] = GUARD_INTERVAL_1_32,

	[1] = GUARD_INTERVAL_1_16,

	[2] = GUARD_INTERVAL_1_8,

	[3] = GUARD_INTERVAL_1_4,

};



u32 sms_to_code_rate_table[] = {

static u32 sms_to_code_rate_table[] = {

	[0] = FEC_1_2,

	[1] = FEC_2_3,

	[2] = FEC_3_4,
@@ -60,14 +60,14 @@ u32 sms_to_code_rate_table[] = { 
};





u32 sms_to_hierarchy_table[] = {

static u32 sms_to_hierarchy_table[] = {

	[0] = HIERARCHY_NONE,

	[1] = HIERARCHY_1,

	[2] = HIERARCHY_2,

	[3] = HIERARCHY_4,

};



u32 sms_to_modulation_table[] = {

static u32 sms_to_modulation_table[] = {

	[0] = QPSK,

	[1] = QAM_16,

	[2] = QAM_64,