Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1481473b authored by Joern Engel's avatar Joern Engel Committed by Nicholas Bellinger
Browse files

target: simplify target_fabric_make_lun error path 



Coverity complained that lun_cg has been dereferenced in all paths
leading to NULL check.  It didn't mention that only a single path could
lead there and the code can be simplified even further.

Signed-off-by: default avatarJoern Engel <joern@logfs.org>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent da0abaee

drivers/target/target_core_fabric_configfs.c

+2 −5
Original line number Diff line number Diff line
@@ -911,15 +911,12 @@ static struct config_group *target_fabric_make_lun( 
				GFP_KERNEL);

	if (!port_stat_grp->default_groups) {

		pr_err("Unable to allocate port_stat_grp->default_groups\n");

		errno = -ENOMEM;

		goto out;

		kfree(lun_cg->default_groups);

		return ERR_PTR(-ENOMEM);

	}

	target_stat_setup_port_default_groups(lun);



	return &lun->lun_group;

out:

	kfree(lun_cg->default_groups);

	return ERR_PTR(errno);

}



static void target_fabric_drop_lun(