Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 13db7734 authored by Radim Krčmář's avatar Radim Krčmář Committed by Paolo Bonzini
Browse files

KVM: x86: don't notify userspace IOAPIC on edge EOI 



On real hardware, edge-triggered interrupts don't set a bit in TMR,
which means that IOAPIC isn't notified on EOI.  Do the same here.

Staying in guest/kernel mode after edge EOI is what we want for most
devices.  If some bugs could be nicely worked around with edge EOI
notifications, we should invest in a better interface.

Signed-off-by: default avatarRadim Krčmář <rkrcmar@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent db2bdcbb

arch/x86/kvm/irq_comm.c

+4 −2
Original line number Original line Diff line number Diff line
@@ -389,13 +389,15 @@ void kvm_scan_ioapic_routes(struct kvm_vcpu *vcpu, u64 *eoi_exit_bitmap) 
	for (i = 0; i < nr_ioapic_pins; ++i) {

	for (i = 0; i < nr_ioapic_pins; ++i) {

		hlist_for_each_entry(entry, &table->map[i], link) {

		hlist_for_each_entry(entry, &table->map[i], link) {

			u32 dest_id, dest_mode;

			u32 dest_id, dest_mode;

			bool level;





			if (entry->type != KVM_IRQ_ROUTING_MSI)

			if (entry->type != KVM_IRQ_ROUTING_MSI)

				continue;

				continue;

			dest_id = (entry->msi.address_lo >> 12) & 0xff;

			dest_id = (entry->msi.address_lo >> 12) & 0xff;

			dest_mode = (entry->msi.address_lo >> 2) & 0x1;

			dest_mode = (entry->msi.address_lo >> 2) & 0x1;

			if (kvm_apic_match_dest(vcpu, NULL, 0, dest_id,

			level = entry->msi.data & MSI_DATA_TRIGGER_LEVEL;

						dest_mode)) {

			if (level && kvm_apic_match_dest(vcpu, NULL, 0,

						dest_id, dest_mode)) {

				u32 vector = entry->msi.data & 0xff;

				u32 vector = entry->msi.data & 0xff;





				__set_bit(vector,

				__set_bit(vector,