Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1318a481 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

genirq: Provide default irq init flags 



Arch code sets it's own irq_desc.status flags right after boot and for
dynamically allocated interrupts. That might involve iterating over a
huge array.

Allow ARCH_IRQ_INIT_FLAGS to set separate flags aside of IRQ_DISABLED
which is the default.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarIngo Molnar <mingo@elte.hu>
parent d895f51e

include/linux/irq.h

+6 −0
Original line number Diff line number Diff line
@@ -214,6 +214,12 @@ struct irq_chip { 
 */

#include <asm/hw_irq.h>



#ifndef ARCH_IRQ_INIT_FLAGS

# define ARCH_IRQ_INIT_FLAGS	0

#endif



#define IRQ_DEFAULT_INIT_FLAGS	(IRQ_DISABLED | ARCH_IRQ_INIT_FLAGS)



struct irqaction;

extern int setup_irq(unsigned int irq, struct irqaction *new);

extern void remove_irq(unsigned int irq, struct irqaction *act);

kernel/irq/chip.c

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ static void dynamic_irq_init_x(unsigned int irq, bool keep_chip_data) 


	/* Ensure we don't have left over values from a previous use of this irq */

	raw_spin_lock_irqsave(&desc->lock, flags);

	desc->status = IRQ_DISABLED;

	desc->status = IRQ_DEFAULT_INIT_FLAGS;

	desc->irq_data.chip = &no_irq_chip;

	desc->handle_irq = handle_bad_irq;

	desc->depth = 1;

kernel/irq/irqdesc.c

+3 −3
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ EXPORT_SYMBOL_GPL(nr_irqs); 
#ifdef CONFIG_SPARSE_IRQ



static struct irq_desc irq_desc_init = {

	.status		= IRQ_DISABLED,

	.status		= IRQ_DEFAULT_INIT_FLAGS,

	.handle_irq	= handle_bad_irq,

	.depth		= 1,

	.lock		= __RAW_SPIN_LOCK_UNLOCKED(irq_desc_init.lock),
@@ -113,7 +113,7 @@ void replace_irq_desc(unsigned int irq, struct irq_desc *desc) 


static struct irq_desc irq_desc_legacy[NR_IRQS_LEGACY] __cacheline_aligned_in_smp = {

	[0 ... NR_IRQS_LEGACY-1] = {

		.status		= IRQ_DISABLED,

		.status		= IRQ_DEFAULT_INIT_FLAGS,

		.handle_irq	= handle_bad_irq,

		.depth		= 1,

		.lock		= __RAW_SPIN_LOCK_UNLOCKED(irq_desc_init.lock),
@@ -204,7 +204,7 @@ out_unlock: 


struct irq_desc irq_desc[NR_IRQS] __cacheline_aligned_in_smp = {

	[0 ... NR_IRQS-1] = {

		.status		= IRQ_DISABLED,

		.status		= IRQ_DEFAULT_INIT_FLAGS,

		.handle_irq	= handle_bad_irq,

		.depth		= 1,

		.lock		= __RAW_SPIN_LOCK_UNLOCKED(irq_desc->lock),