Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12b2f117 authored by Chen Gang's avatar Chen Gang Committed by Linus Torvalds
Browse files

kernel/audit_tree.c: tree will leak memory when failure occurs in audit_trim_trees() 



audit_trim_trees() calls get_tree().  If a failure occurs we must call
put_tree().

[akpm@linux-foundation.org: run put_tree() before mutex_lock() for small scalability improvement]
Signed-off-by: default avatarChen Gang <gang.chen@asianux.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Eric Paris <eparis@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 373e0f34

kernel/audit_tree.c

+1 −1
Original line number Diff line number Diff line
@@ -617,9 +617,9 @@ void audit_trim_trees(void) 
		}

		spin_unlock(&hash_lock);

		trim_marked(tree);

		put_tree(tree);

		drop_collected_mounts(root_mnt);

skip_it:

		put_tree(tree);

		mutex_lock(&audit_filter_mutex);

	}

	list_del(&cursor);