Commit 1298ca46 authored Apr 17, 2013 by Patrick McHardy Committed by David S. Miller Apr 19, 2013

netlink: don't orphan skb in netlink_trim()



Netlink doesn't account skbs to the sending socket, so the there's no
need to orphan the skb before trimming it.

Removing the skb_orphan() call is required for mmap'ed netlink, which uses
a netlink specific skb destructor that must not be invoked before the
final freeing of the skb.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0ebd0ac5

net/netlink/af_netlink.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -851,7 +851,7 @@ static struct sk_buff netlink_trim(struct sk_buff skb, gfp_t allocation)
		{
		int delta;

		skb_orphan(skb);
		WARN_ON(skb->sk != NULL);

		delta = skb->end - skb->tail;
		if (delta * 2 < skb->truesize)