Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1142ab74 authored by Ziqi Chen's avatar Ziqi Chen Committed by Gerrit - the friendly Code Review server
Browse files

usb: dwc3: msm: clear resource on dwc3_msm_probe defer 



In dwc3_msm_probe, when need to defer probe, driver should clear
resource has been allocated and de-attach the children device.
of_platform_depopulate is the complement of of_platform_populate to
remove devices created here. And driver also needs to destroy
workqueue in error case.

Change-Id: I234198eba45842f86c736dd459096ebc4fced807
Signed-off-by: default avatarZiqi Chen <ziqic@codeaurora.org>
parent f1ead4e3

drivers/usb/dwc3/dwc3-msm.c

+4 −10
Original line number Diff line number Diff line
@@ -2898,7 +2898,7 @@ static int dwc3_msm_probe(struct platform_device *pdev) 
	ret = dwc3_msm_get_clk_gdsc(mdwc);

	if (ret) {

		dev_err(&pdev->dev, "error getting clock or gdsc.\n");

		return ret;

		goto err;

	}



	mdwc->id_state = DWC3_ID_FLOAT;
@@ -3206,19 +3206,14 @@ static int dwc3_msm_probe(struct platform_device *pdev) 
	return 0;



put_dwc3:

	platform_device_put(mdwc->dwc3);

	if (mdwc->bus_perf_client)

		msm_bus_scale_unregister_client(mdwc->bus_perf_client);

	of_platform_depopulate(&pdev->dev);

err:

	destroy_workqueue(mdwc->dwc3_wq);

	return ret;

}



static int dwc3_msm_remove_children(struct device *dev, void *data)

{

	device_unregister(dev);

	return 0;

}



static int dwc3_msm_remove(struct platform_device *pdev)

{

	struct dwc3_msm	*mdwc = platform_get_drvdata(pdev);
@@ -3255,8 +3250,7 @@ static int dwc3_msm_remove(struct platform_device *pdev) 


	if (mdwc->hs_phy)

		mdwc->hs_phy->flags &= ~PHY_HOST_MODE;

	platform_device_put(mdwc->dwc3);

	device_for_each_child(&pdev->dev, NULL, dwc3_msm_remove_children);

	of_platform_depopulate(&pdev->dev);



	dbg_event(0xFF, "Remov put", 0);

	pm_runtime_disable(mdwc->dev);