Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0fc81ee3 authored by Mark Brown's avatar Mark Brown Committed by Chris Ball
Browse files

mmc: sdhci: Report failure reasons for all cases in sdhci_add_host() 



For most error conditions sdhci_add_host() will print a diagnostic
message indicating why it failed but there are a few cases where this
does not happen. Add error messages in these cases to aid diagnosis.

Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarChris Ball <cjb@laptop.org>
parent b9929f0e

drivers/mmc/host/sdhci.c

+8 −2
Original line number Original line Diff line number Diff line
@@ -3033,8 +3033,11 @@ int sdhci_add_host(struct sdhci_host *host) 




	ret = request_irq(host->irq, sdhci_irq, IRQF_SHARED,

	ret = request_irq(host->irq, sdhci_irq, IRQF_SHARED,

		mmc_hostname(mmc), host);

		mmc_hostname(mmc), host);

	if (ret)

	if (ret) {

		pr_err("%s: Failed to request IRQ %d: %d\n",

		       mmc_hostname(mmc), host->irq, ret);

		goto untasklet;

		goto untasklet;

	}





	sdhci_init(host, 0);

	sdhci_init(host, 0);
@@ -3051,8 +3054,11 @@ int sdhci_add_host(struct sdhci_host *host) 
	host->led.brightness_set = sdhci_led_control;

	host->led.brightness_set = sdhci_led_control;





	ret = led_classdev_register(mmc_dev(mmc), &host->led);

	ret = led_classdev_register(mmc_dev(mmc), &host->led);

	if (ret)

	if (ret) {

		pr_err("%s: Failed to register LED device: %d\n",

		       mmc_hostname(mmc), ret);

		goto reset;

		goto reset;

	}

#endif

#endif





	mmiowb();

	mmiowb();