Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f5c3afc authored by Richard Leitner's avatar Richard Leitner Committed by Greg Kroah-Hartman
Browse files

iio: ak8975: fix maybe-uninitialized warning 



commit 05be8d4101d960bad271d32b4f6096af1ccb1534 upstream.

If i2c_device_id *id is NULL and acpi_match_device returns NULL too,
then chipset may be unitialized when accessing &ak_def_array[chipset] in
ak8975_probe. Therefore initialize chipset to AK_MAX_TYPE, which will
return an error when not changed.

This patch fixes the following maybe-uninitialized warning:

drivers/iio/magnetometer/ak8975.c: In function ‘ak8975_probe’:
drivers/iio/magnetometer/ak8975.c:788:14: warning: ‘chipset’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
  data->def = &ak_def_array[chipset];

Signed-off-by: default avatarRichard Leitner <dev@g0hl1n.net>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d3cd04a8

drivers/iio/magnetometer/ak8975.c

+1 −1
Original line number Diff line number Diff line
@@ -732,7 +732,7 @@ static int ak8975_probe(struct i2c_client *client, 
	int eoc_gpio;

	int err;

	const char *name = NULL;

	enum asahi_compass_chipset chipset;

	enum asahi_compass_chipset chipset = AK_MAX_TYPE;



	/* Grab and set up the supplied GPIO. */

	if (client->dev.platform_data)