Commit 0d1a9432 authored May 19, 2021 by Dan Carpenter Committed by Greg Kroah-Hartman Jun 03, 2021

staging: emxx_udc: fix loop in _nbu2ss_nuke()



[ Upstream commit e0112a7c9e847ada15a631b88e279d547e8f26a7 ]

The _nbu2ss_ep_done() function calls:

	list_del_init(&req->queue);

which means that the loop will never exit.

Fixes: ca3d253e ("Staging: emxx_udc: Iterate list using list_for_each_entry")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YKUd0sDyjm/lkJfJ@mwanda


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 0e35b745

drivers/staging/emxx_udc/emxx_udc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2193,7 +2193,7 @@ static int _nbu2ss_nuke(struct nbu2ss_udc *udc,
		struct nbu2ss_ep *ep,
		int status)
		{
		struct nbu2ss_req *req;
		struct nbu2ss_req req, n;

		/* Endpoint Disable */
		_nbu2ss_epn_exit(udc, ep);
		@@ -2205,7 +2205,7 @@ static int _nbu2ss_nuke(struct nbu2ss_udc *udc,
		return 0;

		/* called with irqs blocked */
		list_for_each_entry(req, &ep->queue, queue) {
		list_for_each_entry_safe(req, n, &ep->queue, queue) {
		_nbu2ss_ep_done(ep, req, status);
		}