Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c910d28 authored by Li Zefan's avatar Li Zefan Committed by Ingo Molnar
Browse files

sched: fix double kfree in failure path 



It's not the responsibility of init_rootdomain() to free root_domain
allocated by alloc_rootdomain().

Signed-off-by: default avatarLi Zefan <lizf@cn.fujitsu.com>
Reviewed-by: default avatarPekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent d9be28ea

kernel/sched.c

+2 −3
Original line number Diff line number Diff line
@@ -6970,7 +6970,7 @@ static int init_rootdomain(struct root_domain *rd, bool bootmem) 
	}



	if (!alloc_cpumask_var(&rd->span, GFP_KERNEL))

		goto free_rd;

		goto out;

	if (!alloc_cpumask_var(&rd->online, GFP_KERNEL))

		goto free_span;

	if (!alloc_cpumask_var(&rd->rto_mask, GFP_KERNEL))
@@ -6986,8 +6986,7 @@ free_online: 
	free_cpumask_var(rd->online);

free_span:

	free_cpumask_var(rd->span);

free_rd:

	kfree(rd);

out:

	return -ENOMEM;

}