Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a020022 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Jean Delvare
Browse files

hwmon: (ams) Fix permissions on 'joystick' module parameter 



We should not allow writes to the 'joystick' module parameters since
writing there will not trigger creation of the input device. Disable
writes since we provide alternative way of enabling input device via
AMS device's sysfs attribute.

Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
Acked-by: default avatarJohannes Berg <johannes@sipsolutions.net>
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
parent 810ad7b6

drivers/hwmon/ams/ams-input.c

+2 −2
Original line number Diff line number Diff line
@@ -20,11 +20,11 @@ 
#include "ams.h"



static unsigned int joystick;

module_param(joystick, bool, 0644);

module_param(joystick, bool, S_IRUGO);

MODULE_PARM_DESC(joystick, "Enable the input class device on module load");



static unsigned int invert;

module_param(invert, bool, 0644);

module_param(invert, bool, S_IWUSR | S_IRUGO);

MODULE_PARM_DESC(invert, "Invert input data on X and Y axis");



static void ams_idev_poll(struct input_polled_dev *dev)