Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 064181b0 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Wolfram Sang
Browse files

i2c: ismt: issue a warning when fail to request MSI 



Issue the warning in all error paths when unable to register MSI or its
handler.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 6befa6dd

drivers/i2c/busses/i2c-ismt.c

+5 −6
Original line number Diff line number Diff line
@@ -788,11 +788,8 @@ static int ismt_int_init(struct ismt_priv *priv) 


	/* Try using MSI interrupts */

	err = pci_enable_msi(priv->pci_dev);

	if (err) {

		dev_warn(&priv->pci_dev->dev,

			 "Unable to use MSI interrupts, falling back to legacy\n");

	if (err)

		goto intx;

	}



	err = devm_request_irq(&priv->pci_dev->dev,

			       priv->pci_dev->irq,
@@ -805,10 +802,13 @@ static int ismt_int_init(struct ismt_priv *priv) 
		goto intx;

	}



	goto done;

	return 0;



	/* Try using legacy interrupts */

intx:

	dev_warn(&priv->pci_dev->dev,

		 "Unable to use MSI interrupts, falling back to legacy\n");



	err = devm_request_irq(&priv->pci_dev->dev,

			       priv->pci_dev->irq,

			       ismt_do_interrupt,
@@ -820,7 +820,6 @@ intx: 
		return err;

	}



done:

	return 0;

}