Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 05d3ed0a authored by Prarit Bhargava's avatar Prarit Bhargava Committed by Ingo Molnar
Browse files

x86, pci: iommu fix potential overflow in alloc_iommu() 



It is possible that alloc_iommu()'s boundary_size overflows as
dma_get_seg_boundary can return 0xffffffff.  In that case, further usage of
boundary_size triggers a BUG_ON() in the iommu code.

Signed-off-by: default avatarPrarit Bhargava <prarit@redhat.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent c010b2f7

arch/x86/kernel/pci-gart_64.c

+1 −1
Original line number Diff line number Diff line
@@ -93,7 +93,7 @@ static unsigned long alloc_iommu(struct device *dev, int size) 


	base_index = ALIGN(iommu_bus_base & dma_get_seg_boundary(dev),

			   PAGE_SIZE) >> PAGE_SHIFT;

	boundary_size = ALIGN(dma_get_seg_boundary(dev) + 1,

	boundary_size = ALIGN((unsigned long long)dma_get_seg_boundary(dev) + 1,

			      PAGE_SIZE) >> PAGE_SHIFT;



	spin_lock_irqsave(&iommu_bitmap_lock, flags);