Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02519d33 authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Zhang Rui
Browse files

thermal: kirkwood: Fix valid check for thermal register 



The correct value is obtain by first shifting the register by the offset,
later applying the valid mask and finally invert the result.
This check was lacking an extra parenthesis to be strictly correct.

Signed-off-by: default avatarEzequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: default avatarZhang Rui <rui.zhang@intel.com>
parent f8b58705

drivers/thermal/kirkwood_thermal.c

+2 −2
Original line number Diff line number Diff line
@@ -41,8 +41,8 @@ static int kirkwood_get_temp(struct thermal_zone_device *thermal, 
	reg = readl_relaxed(priv->sensor);



	/* Valid check */

	if (!(reg >> KIRKWOOD_THERMAL_VALID_OFFSET) &

	    KIRKWOOD_THERMAL_VALID_MASK) {

	if (!((reg >> KIRKWOOD_THERMAL_VALID_OFFSET) &

	    KIRKWOOD_THERMAL_VALID_MASK)) {

		dev_err(&thermal->device,

			"Temperature sensor reading not valid\n");

		return -EIO;