Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 013f6579 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

i40e: _MASK vs _SHIFT typo in i40e_handle_mdd_event() 



We accidentally mask by the _SHIFT variable.  It means that "event" is
always zero.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Tested-by: default avatarJim Young <jamesx.m.young@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fe0ca732

drivers/net/ethernet/intel/i40e/i40e_main.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -6151,7 +6151,7 @@ static void i40e_handle_mdd_event(struct i40e_pf *pf) 
				I40E_GL_MDET_TX_PF_NUM_SHIFT;

				I40E_GL_MDET_TX_PF_NUM_SHIFT;

		u8 vf_num = (reg & I40E_GL_MDET_TX_VF_NUM_MASK) >>

		u8 vf_num = (reg & I40E_GL_MDET_TX_VF_NUM_MASK) >>

				I40E_GL_MDET_TX_VF_NUM_SHIFT;

				I40E_GL_MDET_TX_VF_NUM_SHIFT;

		u8 event = (reg & I40E_GL_MDET_TX_EVENT_SHIFT) >>

		u8 event = (reg & I40E_GL_MDET_TX_EVENT_MASK) >>

				I40E_GL_MDET_TX_EVENT_SHIFT;

				I40E_GL_MDET_TX_EVENT_SHIFT;

		u8 queue = (reg & I40E_GL_MDET_TX_QUEUE_MASK) >>

		u8 queue = (reg & I40E_GL_MDET_TX_QUEUE_MASK) >>

				I40E_GL_MDET_TX_QUEUE_SHIFT;

				I40E_GL_MDET_TX_QUEUE_SHIFT;
@@ -6165,7 +6165,7 @@ static void i40e_handle_mdd_event(struct i40e_pf *pf) 
	if (reg & I40E_GL_MDET_RX_VALID_MASK) {

	if (reg & I40E_GL_MDET_RX_VALID_MASK) {

		u8 func = (reg & I40E_GL_MDET_RX_FUNCTION_MASK) >>

		u8 func = (reg & I40E_GL_MDET_RX_FUNCTION_MASK) >>

				I40E_GL_MDET_RX_FUNCTION_SHIFT;

				I40E_GL_MDET_RX_FUNCTION_SHIFT;

		u8 event = (reg & I40E_GL_MDET_RX_EVENT_SHIFT) >>

		u8 event = (reg & I40E_GL_MDET_RX_EVENT_MASK) >>

				I40E_GL_MDET_RX_EVENT_SHIFT;

				I40E_GL_MDET_RX_EVENT_SHIFT;

		u8 queue = (reg & I40E_GL_MDET_RX_QUEUE_MASK) >>

		u8 queue = (reg & I40E_GL_MDET_RX_QUEUE_MASK) >>

				I40E_GL_MDET_RX_QUEUE_SHIFT;

				I40E_GL_MDET_RX_QUEUE_SHIFT;