Commit 00bb4471 authored Dec 31, 2015 by Thomas Gleixner Committed by Greg Kroah-Hartman Mar 03, 2016

x86/irq: Remove the cpumask allocation from send_cleanup_vector()



commit 5da0c1217f05d2ccc9a8ed6e6e5c23a8a1d24dd6 upstream.

There is no need to allocate a new cpumask for sending the cleanup vector. The
old_domain mask is now protected by the vector_lock, so we can safely remove
the offline cpus from it and send the IPI with the resulting mask.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Borislav Petkov <bp@alien8.de>
Tested-by: Joe Lawrence <joe.lawrence@stratus.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Jeremiah Mahler <jmmahler@gmail.com>
Cc: andy.shevchenko@gmail.com
Cc: Guenter Roeck <linux@roeck-us.net>
Link: http://lkml.kernel.org/r/20151231160106.967993932@linutronix.de


Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c2b56b62

arch/x86/kernel/apic/vector.c

+3 −13

Original line number	Diff line number	Diff line
		@@ -528,21 +528,11 @@ static struct irq_chip lapic_controller = {
		#ifdef CONFIG_SMP
		static void __send_cleanup_vector(struct apic_chip_data *data)
		{
		cpumask_var_t cleanup_mask;

		raw_spin_lock(&vector_lock);
		cpumask_and(data->old_domain, data->old_domain, cpu_online_mask);
		data->move_in_progress = 0;
		if (unlikely(!alloc_cpumask_var(&cleanup_mask, GFP_ATOMIC))) {
		unsigned int i;

		for_each_cpu_and(i, data->old_domain, cpu_online_mask)
		apic->send_IPI_mask(cpumask_of(i),
		IRQ_MOVE_CLEANUP_VECTOR);
		} else {
		cpumask_and(cleanup_mask, data->old_domain, cpu_online_mask);
		apic->send_IPI_mask(cleanup_mask, IRQ_MOVE_CLEANUP_VECTOR);
		free_cpumask_var(cleanup_mask);
		}
		if (!cpumask_empty(data->old_domain))
		apic->send_IPI_mask(data->old_domain, IRQ_MOVE_CLEANUP_VECTOR);
		raw_spin_unlock(&vector_lock);
		}