Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0041ecfa authored by João Paulo Rechi Vita's avatar João Paulo Rechi Vita Committed by Marcel Holtmann
Browse files

Bluetooth: Check if mode is supported on getsockopt 



Add this check to getsockopt makes possible to fail early instead of
waiting until listen / connect.

Signed-off-by: default avatarJoão Paulo Rechi Vita <jprvita@profusion.mobi>
Acked-by: default avatarGustavo F. Padovan <padovan@profusion.mobi>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent bd3c9e25

net/bluetooth/l2cap.c

+14 −1
Original line number Diff line number Diff line
@@ -1814,9 +1814,22 @@ static int l2cap_sock_setsockopt_old(struct socket *sock, int optname, char __us 
			break;

		}



		l2cap_pi(sk)->mode = opts.mode;

		switch (l2cap_pi(sk)->mode) {

		case L2CAP_MODE_BASIC:

			break;

		case L2CAP_MODE_ERTM:

		case L2CAP_MODE_STREAMING:

			if (enable_ertm)

				break;

			/* fall through */

		default:

			err = -EINVAL;

			break;

		}



		l2cap_pi(sk)->imtu = opts.imtu;

		l2cap_pi(sk)->omtu = opts.omtu;

		l2cap_pi(sk)->mode = opts.mode;

		l2cap_pi(sk)->fcs  = opts.fcs;

		l2cap_pi(sk)->max_tx = opts.max_tx;

		l2cap_pi(sk)->tx_win = (__u8)opts.txwin_size;