Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 001e04bd authored by Pavel Skripkin's avatar Pavel Skripkin Committed by Greg Kroah-Hartman
Browse files

net: moxa: fix UAF in moxart_mac_probe 



commit c78eaeebe855fd93f2e77142ffd0404a54070d84 upstream.

In case of netdev registration failure the code path will
jump to init_fail label:

init_fail:
	netdev_err(ndev, "init failed\n");
	moxart_mac_free_memory(ndev);
irq_map_fail:
	free_netdev(ndev);
	return ret;

So, there is no need to call free_netdev() before jumping
to error handling path, since it can cause UAF or double-free
bug.

Fixes: 6c821bd9 ("net: Add MOXA ART SoCs ethernet driver")
Signed-off-by: default avatarPavel Skripkin <paskripkin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5a37be80

drivers/net/ethernet/moxa/moxart_ether.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -518,10 +518,8 @@ static int moxart_mac_probe(struct platform_device *pdev) 
	SET_NETDEV_DEV(ndev, &pdev->dev);

	SET_NETDEV_DEV(ndev, &pdev->dev);





	ret = register_netdev(ndev);

	ret = register_netdev(ndev);

	if (ret) {

	if (ret)

		free_netdev(ndev);

		goto init_fail;

		goto init_fail;

	}





	netdev_dbg(ndev, "%s: IRQ=%d address=%pM\n",

	netdev_dbg(ndev, "%s: IRQ=%d address=%pM\n",

		   __func__, ndev->irq, ndev->dev_addr);

		   __func__, ndev->irq, ndev->dev_addr);