Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c73ddf7f authored by Deva Ramasubramanian's avatar Deva Ramasubramanian
Browse files

msm: vidc: Check input arguments correctly 



This commit fixes some minor bugs in which input arguments or malloc
return values were being insufficiently validated.

Change-Id: Ib0b3d2ded29384b49ec61a5fc275d3aca1fd6e14
Signed-off-by: default avatarDeva Ramasubramanian <dramasub@codeaurora.org>
parent 4bb26321

drivers/media/platform/msm/vidc/hfi_packetization.c

+1 −1
Original line number Diff line number Diff line
@@ -583,7 +583,7 @@ int create_pkt_cmd_session_parse_seq_header( 
		u32 session_id, struct vidc_seq_hdr *seq_hdr)

{

	int rc = 0;

	if (!pkt || !session_id || seq_hdr)

	if (!pkt || !session_id || !seq_hdr)

		return -EINVAL;



	pkt->size = sizeof(struct hfi_cmd_session_parse_sequence_header_packet);

drivers/media/platform/msm/vidc/msm_vidc_common.c

+1 −1
Original line number Diff line number Diff line
@@ -3149,7 +3149,7 @@ int msm_vidc_trigger_ssr(struct msm_vidc_core *core, 
{

	int rc = 0;

	struct hfi_device *hdev;

	if (!core && !core->device) {

	if (!core || !core->device) {

		dprintk(VIDC_WARN, "Invalid parameters: %p\n", core);

		return -EINVAL;

	}

drivers/media/platform/msm/vidc/msm_vidc_res_parse.c

+1 −1
Original line number Diff line number Diff line
@@ -321,7 +321,7 @@ static int msm_vidc_load_bus_vector(struct platform_device *pdev, 
		bus_pdata->usecase[i].vectors = kzalloc(

			sizeof(*bus_pdata->usecase[i].vectors) * num_ports,

			GFP_KERNEL);

		if (!bus_pdata->usecase) {

		if (!bus_pdata->usecase[i].vectors) {

			dprintk(VIDC_ERR,

				"%s Failed to alloc bus_pdata usecase\n",

				__func__);