Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 31ad645e authored by Shrenuj Bansal's avatar Shrenuj Bansal
Browse files

msm: kgsl: Change struct pointers to void pointers 



Change struct kgsl_ibdesc and kgsl_cmd_syncpoint pointers to void
pointers since we cast them to void __user * anyway. Also, this
enables us to pass pointers to structs other than the above two.

Change-Id: Idc3464b049dfdff51ecd0c32a47d4f5d3b0e4980
Signed-off-by: default avatarShrenuj Bansal <shrenujb@codeaurora.org>
parent 7c4ab635

drivers/gpu/msm/kgsl.c

+6 −8
Original line number Diff line number Diff line
@@ -1891,11 +1891,9 @@ static struct kgsl_cmdbatch *_kgsl_cmdbatch_create_legacy( 
 * Create a command batch from the standard issueibcmds format sent by the user.

 */

static struct kgsl_cmdbatch *_kgsl_cmdbatch_create(struct kgsl_device *device,

		struct kgsl_context *context,

		unsigned int flags,

		struct kgsl_ibdesc __user *cmdlist, unsigned int numcmds,

		struct kgsl_cmd_syncpoint __user *synclist,

		unsigned int numsyncs)

		struct kgsl_context *context, unsigned int flags,

		void __user *cmdlist, unsigned int numcmds,

		void __user *synclist, unsigned int numsyncs)

{

	struct kgsl_cmdbatch *cmdbatch =

		kgsl_cmdbatch_create(device, context, flags, numcmds);
@@ -1905,7 +1903,7 @@ static struct kgsl_cmdbatch *_kgsl_cmdbatch_create(struct kgsl_device *device, 
		return cmdbatch;



	if (!(flags & KGSL_CONTEXT_SYNC)) {

		if (copy_from_user(cmdbatch->ibdesc, (void __user *) cmdlist,

		if (copy_from_user(cmdbatch->ibdesc, cmdlist,

			sizeof(struct kgsl_ibdesc) * numcmds)) {

			ret = -EFAULT;

			goto done;
@@ -1914,7 +1912,7 @@ static struct kgsl_cmdbatch *_kgsl_cmdbatch_create(struct kgsl_device *device, 


	if (synclist && numsyncs) {

		struct kgsl_cmd_syncpoint sync;

		void  __user *uptr = (void __user *) synclist;

		void  __user *uptr = synclist;

		int i;



		for (i = 0; i < numsyncs; i++) {
@@ -1971,7 +1969,7 @@ static long kgsl_ioctl_rb_issueibcmds(struct kgsl_device_private *dev_priv, 
			goto done;



		cmdbatch = _kgsl_cmdbatch_create(device, context, param->flags,

			(struct kgsl_ibdesc __user *)param->ibdesc_addr,

			(void __user *)param->ibdesc_addr,

			 param->numibs, 0, 0);

	} else

		cmdbatch = _kgsl_cmdbatch_create_legacy(device, context, param);