Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit febac9b9 authored by Samuel Ortiz's avatar Samuel Ortiz Committed by David S. Miller
Browse files

[IrDA] stir4200: removing undocumented bits handling 



FIFOCTL_RXERR and FIFOCTL_TXERR are undocumented bits, according to the
Sigmatel datasheet. We should thus not take any assumption on their values
and semantics.

Problem spotted by andrzej zaborowski <balrogg@gmail.com>
Signed-off-by: default avatarSamuel Ortiz <samuel@sortiz.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 895de090

drivers/net/irda/stir4200.c

+0 −15
Original line number Diff line number Diff line
@@ -149,8 +149,6 @@ enum StirFifoCtlMask { 
	FIFOCTL_DIR = 0x10,

	FIFOCTL_CLR = 0x08,

	FIFOCTL_EMPTY = 0x04,

	FIFOCTL_RXERR = 0x02,

	FIFOCTL_TXERR = 0x01,

};



enum StirDiagMask {
@@ -615,19 +613,6 @@ static int fifo_txwait(struct stir_cb *stir, int space) 


		pr_debug("fifo status 0x%lx count %lu\n", status, count);



		/* error when receive/transmit fifo gets confused */

		if (status & FIFOCTL_RXERR) {

			stir->stats.rx_fifo_errors++;

			stir->stats.rx_errors++;

			break;

		}



		if (status & FIFOCTL_TXERR) {

			stir->stats.tx_fifo_errors++;

			stir->stats.tx_errors++;

			break;

		}



		/* is fifo receiving already, or empty */

		if (!(status & FIFOCTL_DIR)

		    || (status & FIFOCTL_EMPTY))