Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f9e9dcb3 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

x86[-64]:Remove 'volatile' from atomic_t 



Any code that relies on the volatile would be a bug waiting to happen
anyway.

Don't encourage people to think that putting 'volatile' on data
structures somehow fixes problems.  We should always use proper locking
(and other serialization) techniques.

Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 16afea02

include/asm-i386/atomic.h

+1 −1
Original line number Diff line number Diff line
@@ -14,7 +14,7 @@ 
 * on us. We need to use _exactly_ the address the user gave us,

 * not some alias that contains the same information.

 */

typedef struct { volatile int counter; } atomic_t;

typedef struct { int counter; } atomic_t;



#define ATOMIC_INIT(i)	{ (i) }

include/asm-x86_64/atomic.h

+1 −1
Original line number Diff line number Diff line
@@ -21,7 +21,7 @@ 
 * on us. We need to use _exactly_ the address the user gave us,

 * not some alias that contains the same information.

 */

typedef struct { volatile int counter; } atomic_t;

typedef struct { int counter; } atomic_t;



#define ATOMIC_INIT(i)	{ (i) }