Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f162e97d authored by Andy Fleming's avatar Andy Fleming Committed by David S. Miller
Browse files

phylib: Remove unnecessary "reset" fixups in genphy_setup_forced 



genphy_setup_forced hasn't actually reset the PHY for a long time,
but a comment to that effect remained in the code, so code continued
to act as if it *had* reset the PHY, and called the necessary fixup
functions to respond to a PHY reset.  With no reset, those functions
are no longer needed, so we remove them.

Signed-off-by: default avatarAndy Fleming <afleming@freescale.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5a5efed4

drivers/net/phy/phy_device.c

+0 −17
Original line number Original line Diff line number Diff line
@@ -517,23 +517,6 @@ int genphy_setup_forced(struct phy_device *phydev) 
	

	

	err = phy_write(phydev, MII_BMCR, ctl);

	err = phy_write(phydev, MII_BMCR, ctl);





	if (err < 0)

		return err;



	/*

	 * Run the fixups on this PHY, just in case the

	 * board code needs to change something after a reset

	 */

	err = phy_scan_fixups(phydev);



	if (err < 0)

		return err;



	/* We just reset the device, so we'd better configure any

	 * settings the PHY requires to operate */

	if (phydev->drv->config_init)

		err = phydev->drv->config_init(phydev);



	return err;

	return err;

}

}