Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee56a4d3 authored by Oliver Neukum's avatar Oliver Neukum Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (8544): gspca: probe/open race. 



The device is flagged present after it is registered. During that window calls
to open() that should work fail with -ENODEV. Reversing the order fixes
the race.

Signed-off-by: default avatarOliver Neukum <oneukum@suse.de>
Acked-by: default avatarHans de Goede <j.w.r.degoede@hhs.nl>
Signed-off-by: default avatarJean-Francois Moine <moinejf@free.fr>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent ee281b85

drivers/media/video/gspca/gspca.c

+1 −1
Original line number Diff line number Diff line
@@ -1758,6 +1758,7 @@ int gspca_dev_probe(struct usb_interface *intf, 
	memcpy(&gspca_dev->fops, &dev_fops, sizeof gspca_dev->fops);

	gspca_dev->vdev.fops = &gspca_dev->fops;

	gspca_dev->fops.owner = module;		/* module protection */

	gspca_dev->present = 1;

	ret = video_register_device(&gspca_dev->vdev,

				  VFL_TYPE_GRABBER,

				  video_nr);
@@ -1766,7 +1767,6 @@ int gspca_dev_probe(struct usb_interface *intf, 
		goto out;

	}



	gspca_dev->present = 1;

	usb_set_intfdata(intf, gspca_dev);

	PDEBUG(D_PROBE, "probe ok");

	return 0;