Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee2d91e2 authored by Robert P. J. Day's avatar Robert P. J. Day Committed by Stefan Richter
Browse files

ieee1394: Remove superfluous calls to kobject_set_name(). 



Unless you're adding a kobject to the sysfs hierarchy, there is no
point setting its kobject name.

Signed-off-by: default avatarRobert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent 9508c208

drivers/ieee1394/dv1394.c

+0 −1
Original line number Diff line number Diff line
@@ -2567,7 +2567,6 @@ static int __init dv1394_init_module(void) 


	cdev_init(&dv1394_cdev, &dv1394_fops);

	dv1394_cdev.owner = THIS_MODULE;

	kobject_set_name(&dv1394_cdev.kobj, "dv1394");

	ret = cdev_add(&dv1394_cdev, IEEE1394_DV1394_DEV, 16);

	if (ret) {

		printk(KERN_ERR "dv1394: unable to register character device\n");

drivers/ieee1394/raw1394.c

+0 −1
Original line number Diff line number Diff line
@@ -3003,7 +3003,6 @@ static int __init init_raw1394(void) 


	cdev_init(&raw1394_cdev, &raw1394_fops);

	raw1394_cdev.owner = THIS_MODULE;

	kobject_set_name(&raw1394_cdev.kobj, RAW1394_DEVICE_NAME);

	ret = cdev_add(&raw1394_cdev, IEEE1394_RAW1394_DEV, 1);

	if (ret) {

		HPSB_ERR("raw1394 failed to register minor device block");

drivers/ieee1394/video1394.c

+0 −1
Original line number Diff line number Diff line
@@ -1503,7 +1503,6 @@ static int __init video1394_init_module (void) 


	cdev_init(&video1394_cdev, &video1394_fops);

	video1394_cdev.owner = THIS_MODULE;

	kobject_set_name(&video1394_cdev.kobj, VIDEO1394_DRIVER_NAME);

	ret = cdev_add(&video1394_cdev, IEEE1394_VIDEO1394_DEV, 16);

	if (ret) {

		PRINT_G(KERN_ERR, "video1394: unable to get minor device block");