Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ea4bc3ec authored by Arun Menon's avatar Arun Menon
Browse files

msm: vidc: avoid usage of output_tag to get session_id 



The firmware will send session_id as part of
struct hfi_msg_event_notify_packet. The driver should use
the session_id in this structure rather than from output_tag.
Without this change release reference event will not
be handled correctly by driver.

Change-Id: I6005482a1b2dfefb6acf0ff797c291197791ca4a
Signed-off-by: default avatarArun Menon <avmenon@codeaurora.org>
parent c99f9b85

drivers/media/platform/msm/vidc/hfi_response_handler.c

+2 −3
Original line number Diff line number Diff line
@@ -182,10 +182,9 @@ static void hfi_process_evt_release_buffer_ref( 
	data = (struct hfi_msg_release_buffer_ref_event_packet *)

				pkt->rg_ext_event_data;





	cmd_done.device_id = device_id;

	cmd_done.session_id =

		((struct hal_session *)data->output_tag)->session_id;

	cmd_done.session_id = ((struct hal_session *) pkt->session_id)->

		session_id;

	cmd_done.status = VIDC_ERR_NONE;

	cmd_done.size = sizeof(struct msm_vidc_cb_event);

drivers/media/platform/msm/vidc/msm_vidc.c

+4 −2
Original line number Diff line number Diff line
@@ -287,8 +287,10 @@ struct buffer_info *device_to_uvaddr(struct msm_vidc_inst *inst, 
	struct buffer_info *dummy = NULL;

	int found = 0;

	int i;

	if (!list || !device_addr) {

		dprintk(VIDC_ERR, "Invalid input\n");

	if (!list || !device_addr || !inst) {

		dprintk(VIDC_ERR,

			"Invalid input- list: %p device_addr: %u inst: %p\n",

			list, device_addr, inst);

		goto err_invalid_input;

	}

	mutex_lock(&inst->lock);

drivers/media/platform/msm/vidc/vidc_hfi.h

+3 −1
Original line number Diff line number Diff line
@@ -139,8 +139,10 @@ struct hfi_extradata_header { 
	(HFI_PROPERTY_PARAM_OX_START + 0x008)

#define HFI_PROPERTY_PARAM_S3D_FRAME_PACKING_EXTRADATA	\

	(HFI_PROPERTY_PARAM_OX_START + 0x009)

#define  HFI_PROPERTY_PARAM_BUFFER_ALLOC_MODE_SUPPORTED	\

#define HFI_PROPERTY_PARAM_ERR_DETECTION_CODE_EXTRADATA \

	(HFI_PROPERTY_PARAM_OX_START + 0x00A)

#define  HFI_PROPERTY_PARAM_BUFFER_ALLOC_MODE_SUPPORTED	\

	(HFI_PROPERTY_PARAM_OX_START + 0x00B)



#define HFI_PROPERTY_CONFIG_OX_START					\

	(HFI_DOMAIN_BASE_COMMON + HFI_ARCH_OX_OFFSET + 0x02000)