Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e70c5dbb authored by Arun Kumar Neelakantam's avatar Arun Kumar Neelakantam
Browse files

soc: qcom: smp2p: Update SMP2P item without sending IRQ 



Every update to the SMP2P item by the local processor triggers a
interrupt to the remote processor to notify about the item change.
Interrupting the remote processor is not required in some special cases
like DSPS processor reading the APPS processor suspend state.

Modify the SMP2P public API to support the SMP2P item update without
triggering interrupt to the remote processor.

Change-Id: Ifb9ae4113ae39bbc1582684d8546524144249eee
Signed-off-by: default avatarArun Kumar Neelakantam <aneela@codeaurora.org>
parent dbd2b72e

drivers/gpio/gpio-msm-smp2p.c

+9 −1
Original line number Diff line number Diff line
@@ -123,6 +123,7 @@ static void smp2p_set_value(struct gpio_chip *cp, unsigned offset, int value) 
	struct smp2p_chip_dev *chip;

	uint32_t data_set;

	uint32_t data_clear;

	bool send_irq;

	int ret;



	if (!cp)
@@ -139,6 +140,13 @@ static void smp2p_set_value(struct gpio_chip *cp, unsigned offset, int value) 
		return;

	}



	if (value & SMP2P_GPIO_NO_INT) {

		value &= ~SMP2P_GPIO_NO_INT;

		send_irq = false;

	} else {

		send_irq = true;

	}



	if (value) {

		data_set = 1 << offset;

		data_clear = 0;
@@ -148,7 +156,7 @@ static void smp2p_set_value(struct gpio_chip *cp, unsigned offset, int value) 
	}



	ret = msm_smp2p_out_modify(chip->out_handle,

			data_set, data_clear);

			data_set, data_clear, send_irq);



	if (ret)

		SMP2P_GPIO("'%s':%d gpio %d set to %d failed (%d)\n",

drivers/soc/qcom/smp2p.c

+15 −8
Original line number Diff line number Diff line
@@ -145,7 +145,7 @@ struct smp2p_version_if { 
	int (*create_entry)(struct msm_smp2p_out *);

	int (*read_entry)(struct msm_smp2p_out *, uint32_t *);

	int (*write_entry)(struct msm_smp2p_out *, uint32_t);

	int (*modify_entry)(struct msm_smp2p_out *, uint32_t, uint32_t);

	int (*modify_entry)(struct msm_smp2p_out *, uint32_t, uint32_t, bool);



	/* inbound entry functions */

	struct smp2p_smem __iomem *(*validate_size)(int remote_pid,
@@ -164,7 +164,8 @@ static void smp2p_find_entry_v0(struct smp2p_smem __iomem *item, 
static int smp2p_out_create_v0(struct msm_smp2p_out *);

static int smp2p_out_read_v0(struct msm_smp2p_out *, uint32_t *);

static int smp2p_out_write_v0(struct msm_smp2p_out *, uint32_t);

static int smp2p_out_modify_v0(struct msm_smp2p_out *, uint32_t, uint32_t);

static int smp2p_out_modify_v0(struct msm_smp2p_out *,

					uint32_t, uint32_t, bool);

static struct smp2p_smem __iomem *smp2p_in_validate_size_v0(int remote_pid,

		struct smp2p_smem __iomem *smem_item, uint32_t size);
@@ -177,7 +178,8 @@ static void smp2p_find_entry_v1(struct smp2p_smem __iomem *item, 
static int smp2p_out_create_v1(struct msm_smp2p_out *);

static int smp2p_out_read_v1(struct msm_smp2p_out *, uint32_t *);

static int smp2p_out_write_v1(struct msm_smp2p_out *, uint32_t);

static int smp2p_out_modify_v1(struct msm_smp2p_out *, uint32_t, uint32_t);

static int smp2p_out_modify_v1(struct msm_smp2p_out *,

					uint32_t, uint32_t, bool);

static struct smp2p_smem __iomem *smp2p_in_validate_size_v1(int remote_pid,

		struct smp2p_smem __iomem *smem_item, uint32_t size);
@@ -677,6 +679,7 @@ static int smp2p_out_write_v1(struct msm_smp2p_out *out_entry, uint32_t data) 
 *

 * @set_mask:  Mask containing the bits that needs to be set.

 * @clear_mask: Mask containing the bits that needs to be cleared.

 * @send_irq: Flag to send interrupt to remote processor.

 * @returns: 0 on success, standard Linux error code otherwise.

 *

 * The clear mask is applied first, so  if a bit is set in both clear and
@@ -685,7 +688,7 @@ static int smp2p_out_write_v1(struct msm_smp2p_out *out_entry, uint32_t data) 
 * Must be called with out_item_lock_lha1 locked.

 */

static int smp2p_out_modify_v1(struct msm_smp2p_out *out_entry,

		uint32_t set_mask, uint32_t clear_mask)

		uint32_t set_mask, uint32_t clear_mask, bool send_irq)

{

	struct smp2p_smem __iomem  *smp2p_h_ptr;

	uint32_t remote_pid;
@@ -711,6 +714,7 @@ static int smp2p_out_modify_v1(struct msm_smp2p_out *out_entry, 
		return -ENODEV;

	}



	if (send_irq)

		smp2p_send_interrupt(remote_pid);

	return 0;

}
@@ -912,10 +916,11 @@ static int smp2p_out_write_v0(struct msm_smp2p_out *out_entry, uint32_t data) 
 *

 * @set_mask:  Mask containing the bits that needs to be set.

 * @clear_mask: Mask containing the bits that needs to be cleared.

 * @send_irq: Flag to send interrupt to remote processor.

 * @returns: -ENODEV

 */

static int smp2p_out_modify_v0(struct msm_smp2p_out *out_entry,

		uint32_t set_mask, uint32_t clear_mask)

		uint32_t set_mask, uint32_t clear_mask, bool send_irq)

{

	SMP2P_ERR("%s: item '%s':%d not yet OPEN\n",

		__func__, out_entry->name, out_entry->remote_pid);
@@ -1325,6 +1330,7 @@ EXPORT_SYMBOL(msm_smp2p_out_write); 
 * @handle: Handle to the smem entry structure.

 * @set_mask: Specifies the bits that needs to be set.

 * @clear_mask: Specifies the bits that needs to be cleared.

 * @send_irq: Flag to send interrupt to remote processor.

 * @returns: 0 on success, standard Linux error code otherwise.

 *

 * The modification is done by doing a bitwise AND of clear mask followed by
@@ -1337,7 +1343,7 @@ EXPORT_SYMBOL(msm_smp2p_out_write); 
 * acceptable.

 */

int msm_smp2p_out_modify(struct msm_smp2p_out *handle, uint32_t set_mask,

							uint32_t clear_mask)

					uint32_t clear_mask, bool send_irq)

{

	int ret = -EINVAL;

	unsigned long flags;
@@ -1355,7 +1361,8 @@ int msm_smp2p_out_modify(struct msm_smp2p_out *handle, uint32_t set_mask, 


	out_item = &out_list[handle->remote_pid];

	spin_lock_irqsave(&out_item->out_item_lock_lha1, flags);

	ret = out_item->ops_ptr->modify_entry(handle, set_mask, clear_mask);

	ret = out_item->ops_ptr->modify_entry(handle, set_mask,

						clear_mask, send_irq);

	spin_unlock_irqrestore(&out_item->out_item_lock_lha1, flags);



	return ret;

drivers/soc/qcom/smp2p_private.h

+1 −0
Original line number Diff line number Diff line
@@ -40,6 +40,7 @@ 
#define SMP2P_FLAGS_RESTART_DONE_MASK 0x1

#define SMP2P_FLAGS_RESTART_ACK_BIT 1

#define SMP2P_FLAGS_RESTART_ACK_MASK 0x2

#define SMP2P_GPIO_NO_INT BIT(1)



#define SMP2P_GET_BITS(hdr_val, mask, bit) \

	(((hdr_val) & (mask)) >> (bit))

drivers/soc/qcom/smp2p_private_api.h

+1 −1
Original line number Diff line number Diff line
@@ -69,7 +69,7 @@ int msm_smp2p_out_close(struct msm_smp2p_out **handle); 
int msm_smp2p_out_read(struct msm_smp2p_out *handle, uint32_t *data);

int msm_smp2p_out_write(struct msm_smp2p_out *handle, uint32_t data);

int msm_smp2p_out_modify(struct msm_smp2p_out *handle, uint32_t set_mask,

	uint32_t clear_mask);

	uint32_t clear_mask, bool send_irq);

int msm_smp2p_in_read(int remote_pid, const char *entry, uint32_t *data);

int msm_smp2p_in_register(int remote_pid, const char *entry,

	struct notifier_block *in_notifier);